Feat convert into GitHub page #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanmanuel-perez
approved these changes
Apr 28, 2021
* DA feedback: Executors registration * DA feedback: Rename promotion to discount when describing discount application * DA feedback: Delete duplicated shipping data object and add missed payment data object * DA feedback: Fix free_shipping property in product data object * DA feedback: Indicate that the executor needs to be registered with a store parameter * DA feedback: Rename Cross items to Cross Items * DA feedback: Add tiers explanation * DA feedback: Adjust readme, openapi update and rebuild * DA feedbac: Add alert to inform that the documentation is on an experimental phase * Add main.css
* Update discount api docs * Apply API modifications for discount calculation
* Add DELETE /promotions/id * chore: build docs Co-authored-by: Martin San Juan <[email protected]>
* Explain amount on line_items documentation * build: rebuild api doc Co-authored-by: Martin San Juan <[email protected]>
* Explain amount on line_items documentation * build: rebuild api doc * docs: update documentation to v2 Co-authored-by: Juan Manuel Perez Desimone <[email protected]>
* Add currency and command order execution disclaimers * Wording feedback * docs: rebuild * rename original_price Co-authored-by: Martin San Juan <[email protected]>
* Fix indentation * Discount openAPI changes * chore: build Co-authored-by: Martin San Juan <[email protected]>
* Fix indent * openAPI: Add PATCH promotions * build * Fix 404 * build Co-authored-by: Martin San Juan <[email protected]>
* Discounts: Update open api - create deactivate promotion * build Co-authored-by: Martin San Juan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Reviewer: Ignore
_sitefiles, are bundled from the md][Rebuild of PR]
What is Jekyll
Jekyll is a Ruby-based static site generator witch allows simpling make websites using a template system base on HTML or markdown. It's also integrated with Github pages.
It provides us many features to reuse some code, but as MPV, transforms our current markdowns in a Github page.
What changes are needed
If we don't want to use any feature, the only difference is the file header:
Instead of:
We should specify the template using the following header:
You can find the documentation about how to run locally on README.md.
Privacy
The documentation will be published as a Github Page, and it's public, but the repository could be private to the people that belong to TiendaNue.
# Resources