load_datagetter_data: Develop check_grant_data_tools_compatible #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwood
force-pushed
the
mw/improve_weird_chars_id_output
branch
2 times, most recently
from
77b8d73
to
39e1960
Compare
R2ZER0
approved these changes
Sep 30, 2024
This adds: * Additional information to the logging suitable for easy consumption including the URL of the problem dataset for easy follow up. * Identifier added to find error output "ProblemChar" easily in logs * CSV-ish structure for ease of finding / reporting the occurrences * Make sure that if the function fails we fall back to accepting the grant
michaelwood
force-pushed
the
mw/improve_weird_chars_id_output
branch
from
39e1960
to
ff56d19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds: