-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add live data split view tutorial #7425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense that if the user opens the split view, the tutorial disappears forever, because it's basically the same action as "Try it".
See my comments below.
ded6ec1
to
5058220
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjamescompton here is my review regarding the design of that feature:
https://www.figma.com/design/7pBLWK4tsjoAbyJq2viMAQ/console?node-id=6608-16341&t=aXv5IH07ZWfRBo8g-1
DM me for any question
7e7b30b
to
3403696
Compare
e9f23d3
to
da1f9f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reviewed API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three things:
- Make
Try it
a primary button and place it on the right.
MakeGot it
a secondary button and place it on the left. Got it
button doesn't close the dialog for me.
Try it
andLive data
buttons open the Split view, but when I close it, the dialog is still here.- Add shadow to the dialog, and to the button (you can send me screenshot to confirm).
84fb3b3
to
c83a306
Compare
c83a306
to
d360059
Compare
Summary
References #7346
Changes
Testing
Steps
View a gateway or application
Live view tutorial should be visible
Click the
x
to close the tutorialOpening the page again will cause the tutorial to be visible again
Click either try it or got it to make the tutorial hide for ever.
How to reset tutorial.seen
Open db
Remove all console preoferences
Results
Screen.Recording.2024-12-04.at.14.18.16.mov
Regressions
...
Notes for Reviewers
Closing the tutorial, then opening and closes the live view causing the tutorial to show again. Show opening the live view make the tutorial hide for ever or should we wait until someone clicks got it or try it.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.