Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live data split view tutorial #7425

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Add live data split view tutorial #7425

merged 3 commits into from
Jan 23, 2025

Conversation

mjamescompton
Copy link
Contributor

@mjamescompton mjamescompton commented Dec 4, 2024

Summary

References #7346

Changes

  • Update users store field mask
  • Update live view button stying
  • Add Live view tutorial

Testing

Steps

View a gateway or application
Live view tutorial should be visible
Click the x to close the tutorial
Opening the page again will cause the tutorial to be visible again
Click either try it or got it to make the tutorial hide for ever.

How to reset tutorial.seen

Open db

tools/bin/mage dev:dbsql

Remove all console preoferences

UPDATE users SET console_preferences = NULL WHERE primary_email_address= '[email protected]';
Results
Screenshot 2024-12-04 at 14 17 26
Screen.Recording.2024-12-04.at.14.18.16.mov
Regressions

...

Notes for Reviewers

Closing the tutorial, then opening and closes the live view causing the tutorial to show again. Show opening the live view make the tutorial hide for ever or should we wait until someone clicks got it or try it.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@mjamescompton mjamescompton self-assigned this Dec 4, 2024
@mjamescompton mjamescompton requested review from a team as code owners December 4, 2024 13:23
Copy link
Contributor

@ryaplots ryaplots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense that if the user opens the split view, the tutorial disappears forever, because it's basically the same action as "Try it".

See my comments below.

pkg/webui/console/components/live-data-button/index.js Outdated Show resolved Hide resolved
pkg/webui/console/components/live-data-button/index.js Outdated Show resolved Hide resolved
pkg/webui/console/containers/event-split-frame/index.js Outdated Show resolved Hide resolved
pkg/webui/locales/en-duplicates.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added c/identity server This is related to the Identity Server compat/db This could affect Database compatibility ui/web This is related to a web interface labels Dec 6, 2024
Copy link
Contributor

@pierrephz pierrephz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjamescompton here is my review regarding the design of that feature:

https://www.figma.com/design/7pBLWK4tsjoAbyJq2viMAQ/console?node-id=6608-16341&t=aXv5IH07ZWfRBo8g-1

DM me for any question

Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed API

api/ttn/lorawan/v3/user.proto Show resolved Hide resolved
Copy link
Contributor

@pierrephz pierrephz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three things:

  1. Make Try it a primary button and place it on the right.
    Make Got it a secondary button and place it on the left.
  2. Got it button doesn't close the dialog for me.
    Try it and Live data buttons open the Split view, but when I close it, the dialog is still here.
  3. Add shadow to the dialog, and to the button (you can send me screenshot to confirm).

@KrishnaIyer KrishnaIyer disabled auto-merge January 23, 2025 08:23
@KrishnaIyer KrishnaIyer merged commit e5ede19 into v3.33 Jan 23, 2025
15 of 16 checks passed
@KrishnaIyer KrishnaIyer deleted the feature/live-data branch January 23, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/identity server This is related to the Identity Server compat/db This could affect Database compatibility ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants