Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support migration to uint32 RSSI for TTIGW protocol #7355

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

johanstokking
Copy link
Member

Summary

Internal reference https://github.com/TheThingsIndustries/gateway/issues/32

This supports migrating from float RSSI values to uint32 in protobuf, which are more bandwidth efficient.

Changes

  • Support reading both the (now deprecated) float as well as the new uint32 fields

Testing

Steps
  1. Connect The Things Indoor Gateway Pro
  2. Observe that LoRa channel and signal RSSI in uplink messages
  3. Perform a WiFi access point scan
Results

The RSSI values (including the WiFi AP signal strength) should make sense (i.e. not 0).

Regressions

None

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking johanstokking requested review from a team as code owners October 23, 2024 12:15
@johanstokking johanstokking added this to the v3.32.2 milestone Oct 23, 2024
@johanstokking johanstokking self-assigned this Oct 23, 2024
@github-actions github-actions bot added c/gateway server This is related to the Gateway Server dependencies Pull requests that update a dependency file tooling Development tooling labels Oct 23, 2024
@johanstokking johanstokking merged commit b47771d into v3.32 Oct 23, 2024
15 of 16 checks passed
@johanstokking johanstokking deleted the feature/ttigw-uint32-rssi branch October 23, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/gateway server This is related to the Gateway Server dependencies Pull requests that update a dependency file tooling Development tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants