Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS migration improvement #7354

Merged
merged 5 commits into from
Oct 23, 2024
Merged

IS migration improvement #7354

merged 5 commits into from
Oct 23, 2024

Conversation

nicholaspcr
Copy link
Contributor

Summary

Counterpart of https://github.com/TheThingsIndustries/lorawan-stack/pull/4418

Changes

  • Update migrations to only be considered applied after they are successful.
  • Update migrations names to have .tx.(up|down).sql as its new suffix, forcing them to run in a transaction.

Testing

Steps

Initialised the database using tools/bin/mage dev:dbStart dev:initMTStack and there are no errors.

Regressions

This PR changes the logic of what is considered a successful migration but it should not have an impact on the contents of any migration.

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@nicholaspcr nicholaspcr added the c/identity server This is related to the Identity Server label Oct 22, 2024
@nicholaspcr nicholaspcr added this to the v3.32.2 milestone Oct 22, 2024
@nicholaspcr nicholaspcr self-assigned this Oct 22, 2024
@nicholaspcr nicholaspcr requested review from a team as code owners October 22, 2024 20:29
@KrishnaIyer KrishnaIyer changed the title US migration improvement IS migration improvement Oct 23, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@johanstokking johanstokking merged commit 6045a69 into v3.32 Oct 23, 2024
9 of 10 checks passed
@johanstokking johanstokking deleted the is/migration-improvement branch October 23, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/identity server This is related to the Identity Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants