Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gs: Fix mutated event data causing panics (evtGatewayConnectionStats) #7332

Merged
merged 1 commit into from
Oct 11, 2024
Merged

gs: Fix mutated event data causing panics (evtGatewayConnectionStats) #7332

merged 1 commit into from
Oct 11, 2024

Conversation

vlasebian
Copy link
Contributor

@vlasebian vlasebian commented Oct 9, 2024 •
edited
Loading

Summary

References support issue #1163.

Changes

  • Clone event data for evtGatewayConnectionStats before publishing

Testing

TODO

Regressions

None.

Notes for Reviewers

None.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@vlasebian vlasebian self-assigned this Oct 9, 2024
@github-actions github-actions bot added the c/gateway server This is related to the Gateway Server label Oct 9, 2024
johanstokking
johanstokking reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, please do this in the caller, add a comment that relates to the mutation.

@vlasebian vlasebian force-pushed the 1163-support-gs-mutated-event-data branch from 84fa036 to dfece98 Compare October 10, 2024 08:30
@vlasebian vlasebian force-pushed the 1163-support-gs-mutated-event-data branch from dfece98 to a2cf594 Compare October 10, 2024 08:57
@vlasebian vlasebian marked this pull request as ready for review October 10, 2024 09:17
@vlasebian vlasebian requested a review from a team as a code owner October 10, 2024 09:17
@vlasebian
Copy link
Contributor Author

I'm not really sure how can I test this change.

@vlasebian vlasebian merged commit bb6b88b into v3.32 Oct 11, 2024
12 of 13 checks passed
@vlasebian vlasebian deleted the 1163-support-gs-mutated-event-data branch October 11, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstokking johanstokking johanstokking approved these changes

@KrishnaIyer KrishnaIyer Awaiting requested review from KrishnaIyer KrishnaIyer is a code owner automatically assigned from TheThingsNetwork/stack-reviewers-11

Assignees

@vlasebian vlasebian

Labels
c/gateway server This is related to the Gateway Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlasebian @johanstokking