Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mage target for serve dev webui tool #7331

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

kschiffer
Copy link
Contributor

Summary

This PR adds the serve dev webui tool as a mage target, so that it can also be run via tools/bin/mage dev:serveDevWebui.

Changes

  • Rename the tool from serve-dev-stack (clashing with existing mage target) to serve-dev-webui
  • Add a new mage target dev:serveDevWebui to the Dev module

Notes for Reviewers

Since this tool should become the unified go-to way of running the stack for frontend development, it should also have an appropriate mage target.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added the tooling Development tooling label Oct 9, 2024
@kschiffer kschiffer self-assigned this Oct 9, 2024
@kschiffer kschiffer requested review from a team as code owners October 9, 2024 13:47
@johanstokking johanstokking merged commit b98a593 into v3.32 Oct 11, 2024
15 of 16 checks passed
@johanstokking johanstokking deleted the feature/serve-dev-webui branch October 11, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Development tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants