-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed gateway integration #7206
Conversation
Awesome, will test this as well. You should be able to drop two of my commits in your trail, see the list here. |
Can we hide the They are basically intended to render the Managed Gateway panel, not really as events. It's a bit weird they appear immediately when opening the gateway. |
|
Ethernet is (typically) always enabled. The checkbox is more for customizing ethernet settings. Please update the checkbox label. |
b33ec93
to
8218bc6
Compare
943ce0c
to
6757913
Compare
@johanstokking Yes the image is static. |
OK, it shouldn't be. Let's remove the image for now then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work! From my manual testing, it appears quite thorough and the end-to-end test should reflect that as well. Also styling wise, it was quite on point, I've just added a small fix commit.
Please see my comments. Most notably, error handling is somewhat stubbed still.
...sole/containers/gateway-managed-gateway/connection-settings/ethernet-settings-form-fields.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/gateway-managed-gateway/connection-settings/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/gateway-managed-gateway/wifi-profiles/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/containers/gateway-managed-gateway/wifi-profiles/index.js
Outdated
Show resolved
Hide resolved
...ainers/gateway-onboarding-form/gateway-provisioning-form/gateway-claim-form-section/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/store/middleware/logics/connection-profiles.js
Outdated
Show resolved
Hide resolved
992f25e
to
687fcad
Compare
Summary
Integration of managed gateway functionality.
Changes
Testing
Steps
Results
Notes for Reviewers
The base branch will be changed to current master.
@kschiffer Please provide tooltip content and correct doc links
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.