Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed gateway integration #7206

Merged
merged 55 commits into from
Aug 16, 2024
Merged

Conversation

PavelJankoski
Copy link
Contributor

@PavelJankoski PavelJankoski commented Jul 30, 2024

Summary

Integration of managed gateway functionality.

Changes

  • New menu item for managed gateway in the gateway details.
  • Connection settings and wifi profiles screens.

Testing

Steps
  1. Login to console.
  2. Go to gateways screen.
  3. Click on some managed gateway.
  4. In the gateway details screen go to connection settings and wifi profiles screens.
  5. Try all CRUD operations in those screens.
Results

Notes for Reviewers

The base branch will be changed to current master.

@kschiffer Please provide tooltip content and correct doc links

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added this to the 2024 Q3 milestone Jul 30, 2024
@PavelJankoski PavelJankoski self-assigned this Jul 30, 2024
@PavelJankoski PavelJankoski requested a review from a team as a code owner July 30, 2024 12:38
@github-actions github-actions bot added the ui/web This is related to a web interface label Jul 30, 2024
@johanstokking
Copy link
Member

Awesome, will test this as well.

You should be able to drop two of my commits in your trail, see the list here.

@johanstokking
Copy link
Member

Can we hide the gcs.managed.* events from the event data view?

They are basically intended to render the Managed Gateway panel, not really as events. It's a bit weird they appear immediately when opening the gateway.

@johanstokking
Copy link
Member

  • Can you take the model from the managed gateway update message for the title, instead of "Managed gateway" ?
  • Where does the image come from? Is that static?
  • If I want to specify a WiFi profile just for this gateway, it still asks for a Profile Name. There should not be a Profile Name prompted, it should be a randomly generated one.

@johanstokking
Copy link
Member

Ethernet is (typically) always enabled. The checkbox is more for customizing ethernet settings. Please update the checkbox label.

Base automatically changed from feature/tti-gtw-lorapf to v3.32 July 31, 2024 20:20
@johanstokking johanstokking modified the milestones: 2024 Q3, v3.32.0 Aug 6, 2024
@PavelJankoski PavelJankoski force-pushed the feature/gateway-integration branch 5 times, most recently from 943ce0c to 6757913 Compare August 8, 2024 15:51
@PavelJankoski
Copy link
Contributor Author

  • Where does the image come from? Is that static?

@johanstokking Yes the image is static.

@johanstokking
Copy link
Member

  • Where does the image come from? Is that static?

@johanstokking Yes the image is static.

OK, it shouldn't be. Let's remove the image for now then.

@johanstokking johanstokking requested review from a team as code owners August 12, 2024 09:25
@github-actions github-actions bot added dependencies Pull requests that update a dependency file tooling Development tooling labels Aug 12, 2024
Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work! From my manual testing, it appears quite thorough and the end-to-end test should reflect that as well. Also styling wise, it was quite on point, I've just added a small fix commit. 

Please see my comments. Most notably, error handling is somewhat stubbed still.

@johanstokking johanstokking requested a review from a team as a code owner August 15, 2024 11:59
@PavelJankoski PavelJankoski changed the base branch from v3.32 to release/v3.32.0 August 15, 2024 17:24
@PavelJankoski PavelJankoski merged commit 00baa28 into release/v3.32.0 Aug 16, 2024
15 checks passed
@PavelJankoski PavelJankoski deleted the feature/gateway-integration branch August 16, 2024 13:25
@kschiffer kschiffer restored the feature/gateway-integration branch August 20, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/gateway conf server This is related to the Gateway Configuration Server c/gateway server This is related to the Gateway Server dependencies Pull requests that update a dependency file tooling Development tooling ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants