Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix middleware error #6427

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Fix middleware error #6427

merged 2 commits into from
Aug 2, 2023

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Aug 2, 2023

Summary

Fixing this error I stumbled upon during the refactoring. The Organization Collaborator List was broken due to:
Screenshot 2023-08-02 at 12 18 34

Changes

  • Fix callback

Testing

Manually

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots self-assigned this Aug 2, 2023
@github-actions github-actions bot added the ui/web This is related to a web interface label Aug 2, 2023
@ryaplots ryaplots added bug Something isn't working and removed ui/web This is related to a web interface labels Aug 2, 2023
@kschiffer
Copy link
Contributor

Can you also check why this wasn't caught by the e2e?

@github-actions github-actions bot added the ui/web This is related to a web interface label Aug 2, 2023
@ryaplots
Copy link
Contributor Author

ryaplots commented Aug 2, 2023 •
edited
Loading

Can you also check why this wasn't caught by the e2e?

We weren't checking if the added collaborator was in the collaborator list. That's fixed now.

@ryaplots ryaplots merged commit b69f9d2 into v3.27 Aug 2, 2023
13 checks passed
@ryaplots ryaplots deleted the fix/middleware-error branch August 2, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschiffer kschiffer kschiffer approved these changes

@mjamescompton mjamescompton Awaiting requested review from mjamescompton mjamescompton is a code owner

Assignees

@ryaplots ryaplots

Labels
bug Something isn't working ui/web This is related to a web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryaplots @kschiffer