Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support gateways without location #6409

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Support gateways without location #6409

merged 1 commit into from
Jul 26, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

References https://the-things-industries.sentry.io/issues/4341403408/?alert_rule_id=1003576&alert_timestamp=1690371410313&alert_type=email&environment=ttn-prod-eu1&project=2682566&referrer=alert_email

Changes

  • While translating the RxMetadata to the internal structs, do not assume that all gateways have a location.

Testing

Local.

Regressions

N/A.

Notes for Reviewers

@johanstokking please take a look. This will be backported.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added the bug Something isn't working label Jul 26, 2023
@adriansmares adriansmares added this to the v3.27.1 milestone Jul 26, 2023
@adriansmares adriansmares self-assigned this Jul 26, 2023
@github-actions github-actions bot added the c/application server This is related to the Application Server label Jul 26, 2023
@adriansmares adriansmares marked this pull request as ready for review July 26, 2023 12:02
@adriansmares adriansmares merged commit 851e8b5 into v3.27 Jul 26, 2023
13 checks passed
@adriansmares adriansmares deleted the fix/nil-location branch July 26, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstokking johanstokking johanstokking approved these changes

@KrishnaIyer KrishnaIyer Awaiting requested review from KrishnaIyer KrishnaIyer is a code owner

Assignees

@adriansmares adriansmares

Labels
bug Something isn't working c/application server This is related to the Application Server
Projects
None yet
Milestone
v3.27.1
Development

Successfully merging this pull request may close these issues.
2 participants
@adriansmares @johanstokking