Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't store empty LoRa GLS package associations #6395

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Don't store empty LoRa GLS package associations #6395

merged 2 commits into from
Jul 18, 2023

Conversation

cvetkovski98
Copy link
Member

@cvetkovski98 cvetkovski98 commented Jul 12, 2023 •
edited
Loading

Summary

Reduce the number of stored fields in the package data associations by allowing nil fields. Remove the package data association if the data is empty.

Closes #6342

Changes

  • Made the data fields in the LoRa Cloud GLS integration nil-able
  • Split the data merging logic from the validation
  • Added unit tests

Testing

  • Manual using the simulate command
  • Unit tests
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@cvetkovski98 cvetkovski98 linked an issue Jul 12, 2023 that may be closed by this pull request
Optimize package data associations for LoRa Cloud Modem & Geolocation Services #6342
Closed
4 tasks
@github-actions github-actions bot added the c/application server This is related to the Application Server label Jul 12, 2023
@cvetkovski98 cvetkovski98 self-assigned this Jul 13, 2023
@cvetkovski98 cvetkovski98 added this to the v3.27.0 milestone Jul 13, 2023
@cvetkovski98 cvetkovski98 force-pushed the feature/optimize-package-associations branch from c74e70a to 818bf57 Compare July 13, 2023 14:35
@cvetkovski98 cvetkovski98 force-pushed the feature/optimize-package-associations branch from 818bf57 to 58c6cc1 Compare July 13, 2023 14:41
@cvetkovski98 cvetkovski98 changed the title Automatically remove empty LoRa GLS package associations Don't store empty LoRa GLS package associations Jul 13, 2023
@cvetkovski98 cvetkovski98 marked this pull request as ready for review July 13, 2023 14:56
adriansmares
adriansmares reviewed Jul 18, 2023
View reviewed changes
Copy link
Contributor

@adriansmares adriansmares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small request regarding return format.

pkg/applicationserver/io/packages/loragls/v3/data.go Show resolved Hide resolved
pkg/applicationserver/io/packages/loragls/v3/package.go Outdated Show resolved Hide resolved
@cvetkovski98 cvetkovski98 merged commit bcd1284 into v3.27 Jul 18, 2023
14 of 15 checks passed
@cvetkovski98 cvetkovski98 deleted the feature/optimize-package-associations branch July 18, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansmares adriansmares adriansmares approved these changes

@johanstokking johanstokking Awaiting requested review from johanstokking johanstokking is a code owner

@KrishnaIyer KrishnaIyer Awaiting requested review from KrishnaIyer KrishnaIyer is a code owner

Assignees

@cvetkovski98 cvetkovski98

Labels
c/application server This is related to the Application Server
Projects
None yet
Milestone
v3.27.0
Development

Successfully merging this pull request may close these issues.

Optimize package data associations for LoRa Cloud Modem & Geolocation Services
2 participants
@cvetkovski98 @adriansmares