Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove body from Unclaim request #6381

Merged
merged 6 commits into from
Jul 12, 2023
Merged

Remove body from Unclaim request #6381

merged 6 commits into from
Jul 12, 2023

Conversation

KrishnaIyer
Copy link
Member

Summary

Remove body from Unclaim request. Refs #6325

Changes

  • Extract only the API and the tooling change for a backport.

Testing

Console E2E should cover this. Will test in staging.

Regressions

This fixes a bug.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@KrishnaIyer KrishnaIyer added this to the v3.27.0 milestone Jul 5, 2023
@KrishnaIyer KrishnaIyer self-assigned this Jul 5, 2023
@github-actions github-actions bot added compat/api This could affect API compatibility tooling Development tooling labels Jul 5, 2023
@github-actions github-actions bot added the ui/web This is related to a web interface label Jul 6, 2023
@KrishnaIyer KrishnaIyer force-pushed the feature/remove-body-unclaim branch 2 times, most recently from b1ab62a to 09018be Compare July 6, 2023 11:49
@KrishnaIyer KrishnaIyer marked this pull request as ready for review July 6, 2023 11:50
@KrishnaIyer
Copy link
Member Author

@mjamescompton / @kschiffer: Can you quickly look at the console change? This is a bug that I'd like to patch in the current release.

@KrishnaIyer KrishnaIyer force-pushed the feature/remove-body-unclaim branch 2 times, most recently from 695f2d9 to d0f2020 Compare July 10, 2023 12:50
@github-actions github-actions bot removed the ui/web This is related to a web interface label Jul 10, 2023
@KrishnaIyer KrishnaIyer force-pushed the feature/remove-body-unclaim branch 4 times, most recently from 2bbad85 to c912678 Compare July 10, 2023 13:59
KrishnaIyer
KrishnaIyer commented Jul 10, 2023
View reviewed changes
sdk/js/src/util/bytes.js Outdated Show resolved Hide resolved
@github-actions github-actions bot added the ui/web This is related to a web interface label Jul 11, 2023
adriansmares
adriansmares approved these changes Jul 11, 2023
View reviewed changes
sdk/js/src/util/bytes.js Outdated Show resolved Hide resolved
@KrishnaIyer KrishnaIyer mentioned this pull request Jul 12, 2023
Closed
5 tasks
@KrishnaIyer KrishnaIyer merged commit 0ede549 into v3.27 Jul 12, 2023
15 of 16 checks passed
@KrishnaIyer KrishnaIyer deleted the feature/remove-body-unclaim branch July 12, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschiffer kschiffer kschiffer approved these changes

@adriansmares adriansmares adriansmares approved these changes

@ryaplots ryaplots Awaiting requested review from ryaplots ryaplots is a code owner

@mjamescompton mjamescompton Awaiting requested review from mjamescompton mjamescompton is a code owner

@johanstokking johanstokking Awaiting requested review from johanstokking johanstokking is a code owner

Assignees

@KrishnaIyer KrishnaIyer

Labels
compat/api This could affect API compatibility tooling Development tooling ui/web This is related to a web interface
Projects
None yet
Milestone
v3.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@KrishnaIyer @kschiffer @adriansmares