Event filtering using the backend #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschiffer
added
c/console
github-actions
bot
added
compat/api
htdvisser
force-pushed
the
feature/2231-event-filter
branch
from
90d99de to
012b05c
Compare
kschiffer
force-pushed
the
feature/2231-event-filter
branch
3 times, most recently
from
6afc80b to
5127786
Compare
kschiffer
requested review from
adriansmares,
bafonins,
htdvisser and
johanstokking
as code owners
adriansmares
approved these changes
Nov 9, 2021
| errUnknownEventName = errors.DefineInvalidArgument("unknown_event_name", "unknown event `{name}`") | ||
| ) | ||
|
|
||
| func (srv *EventsServer) processNames(names ...string) ([]string, error) { |
bafonins
approved these changes
Nov 10, 2021
| 'synthetic.status.filter_disabled:type': 'Filter disabled', | ||
| 'synthetic.status.filter_disabled:preview': 'The previously set event filter has been disabled', | ||
| 'synthetic.status.filter_disabled:details': | ||
| 'The event stream is will not be filtered any more. This means that you will see all events that come out of the event stream for this entity.', |
There was a problem hiding this comment.
Suggested change
| 'The event stream is will not be filtered any more. This means that you will see all events that come out of the event stream for this entity.', | |
| 'The event stream will not be filtered any more. This means that you will see all events that come out of the event stream for this entity.', |
kschiffer
force-pushed
the
feature/2231-event-filter
branch
from
5127786 to
7b4835a
Compare
htdvisser
reviewed
Nov 10, 2021
kschiffer
force-pushed
the
feature/2231-event-filter
branch
from
7b4835a to
8cd6eaf
Compare
kschiffer
force-pushed
the
feature/2231-event-filter
branch
from
8cd6eaf to
d7e1025
Compare
|
@johanstokking Can you review in this case since this PR is co-authored by @htdvisser. I cannot merge otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces filtering logic for events in the backend, as well as the Console making use of the new feature. Client-side filtering is hence retired.
Referencing #2231
Changes
namespropTesting
Manual testing.
Regressions
Possible but hard to check right now. We should check this closely once on staging.
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.