-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out verbose events in the Console #4150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, is this a temporary solution for #2231? What is the plan there?
I experience significant delay when opening event details for both development and production builds. This does not happen to me on the latest v3.12
branch as well as on staging Console
Also, Im getting the following warning when opening the events tab:
Could not load worker TypeError: name.split is not a function
at AppConfig.exports.moduleUrl (ace.js:3722)
at WorkerClient.$createWorkerFromOldConfig (ace.js:19056)
at new WorkerClient (ace.js:19034)
at Mode.createWorker (json.js?818b:300)
at EditSession.$startWorker (ace.js:9735)
at EditSession.$onChangeMode (ace.js:9691)
at EditSession.setMode (ace.js:9655)
at ReactAce.libs_0dc51107365406cd4f90../node_modules/react-ace/lib/ace.js.ReactAce.componentDidMount (ace.js:73)
at ReactAce.eval (react-hot-loader.development.js?c2cb:707)
at commitLifeCycles (react-dom.development.js?7f13:20664)
at ReactAce (eval at ES6ProxyComponentFactory (webpack-internal:///./node_modules/react-hot-loader/dist/react-hot-loader.development.js), <anonymous>:14:7)
at div
at CodeEditor (eval at ES6ProxyComponentFactory (webpack-internal:///./node_modules/react-hot-loader/dist/react-hot-loader.development.js), <anonymous>:14:7)
at eval (webpack-internal:///./pkg/webui/console/components/events/details/raw.js:168:24)
at div
at EventDetails (webpack-internal:///./pkg/webui/console/components/events/details/index.js:306:24)
Yes this is a temporary fix for the event stream being too verbose. This is to improve the UX already until the new event UX is designed and implemented.
I think this was introduced via #4104, see also securingsincity/react-ace#732 I downgraded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, downgrading react-ace
solves perf issues
fecfd64
to
fb0fab5
Compare
fb0fab5
to
9f1aa8c
Compare
Summary
This PR will apply a toggle-able verbosity filter to the event stream which will by default filter out all events that are not typically of direct interest.
References #2231
With verbose mode deactivated (default) only the following events will be ingested:
Changes
<Events />
component to enable filtering out verbose eventsTesting
Manual testing in the staging environment
Regressions
This could affect event ingestion in the Console
Notes for Reviewers
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.