-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pausing of event streams in Console #3388
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschiffer
added
bug
Something isn't working
c/console
This is related to the Console
technical debt
Not necessarily broken, but could be done better/cleaner
ui/web
This is related to a web interface
needs/backport
Needs to be backported to previous versions that are maintained
labels
Oct 20, 2020
github-actions
bot
added
the
documentation
This involves writing user documentation
label
Oct 20, 2020
kschiffer
force-pushed
the
fix/3324-event-stream-pause
branch
from
October 20, 2020 21:59
8f44d24
to
ed534e5
Compare
bafonins
reviewed
Oct 22, 2020
pkg/webui/console/store/index.js
Outdated
@@ -29,7 +29,17 @@ import requestPromiseMiddleware from './middleware/request-promise-middleware' | |||
import logics from './middleware/logics' | |||
|
|||
const composeEnhancers = (dev && window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__) || compose | |||
let middlewares = [requestPromiseMiddleware, createLogicMiddleware(logics)] | |||
|
|||
const userTimingMiddleware = () => next => action => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this in master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this slipped through from performance debugging. Will remove.
kschiffer
force-pushed
the
fix/3324-event-stream-pause
branch
from
October 26, 2020 10:58
ed534e5
to
90074c4
Compare
bafonins
approved these changes
Oct 26, 2020
kschiffer
removed
the
needs/backport
Needs to be backported to previous versions that are maintained
label
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
c/console
This is related to the Console
documentation
This involves writing user documentation
technical debt
Not necessarily broken, but could be done better/cleaner
ui/web
This is related to a web interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the logic of event pausing to pause event ingestion on store level rather than component level. This means that the Console will not save up events that arrived during the pause anymore.
Closes #3324
Changes
shouldUpdate
type logic for the event componentpause
propTesting
Manual testing.
Regressions
This might cause issues wrt correct event display during paused and resumed state
Notes for Reviewers
This will not interrupt the stream connection itself but only interrupt the adding of new events to the store. The event connection needs to persist e.g. in order to detect heartbeat events for end devices.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.