Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pausing of event streams in Console #3388

Merged
merged 7 commits into from
Oct 26, 2020
Merged

Conversation

kschiffer
Copy link
Contributor

@kschiffer kschiffer commented Oct 20, 2020

Summary

This PR changes the logic of event pausing to pause event ingestion on store level rather than component level. This means that the Console will not save up events that arrived during the pause anymore.

Closes #3324

image

Changes

  • Extend store logic to allow for pausing ingestion of new events when the stream is paused
  • Remove shouldUpdate type logic for the event component
  • Add respective synthetic events for pausing and resuming the event stream
  • Update event containers to pass down new action dispatches and selected pause prop
  • Adjust the styling of the pause button a bit to make the paused state more noticeable

Testing

Manual testing.

Regressions

This might cause issues wrt correct event display during paused and resumed state

Notes for Reviewers

This will not interrupt the stream connection itself but only interrupt the adding of new events to the store. The event connection needs to persist e.g. in order to detect heartbeat events for end devices.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added bug Something isn't working c/console This is related to the Console technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface needs/backport Needs to be backported to previous versions that are maintained labels Oct 20, 2020
@kschiffer kschiffer added this to the October 2020 milestone Oct 20, 2020
@kschiffer kschiffer self-assigned this Oct 20, 2020
@github-actions github-actions bot added the documentation This involves writing user documentation label Oct 20, 2020
@kschiffer kschiffer force-pushed the fix/3324-event-stream-pause branch from 8f44d24 to ed534e5 Compare October 20, 2020 21:59
@@ -29,7 +29,17 @@ import requestPromiseMiddleware from './middleware/request-promise-middleware'
import logics from './middleware/logics'

const composeEnhancers = (dev && window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__) || compose
let middlewares = [requestPromiseMiddleware, createLogicMiddleware(logics)]

const userTimingMiddleware = () => next => action => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this slipped through from performance debugging. Will remove.

@kschiffer kschiffer force-pushed the fix/3324-event-stream-pause branch from ed534e5 to 90074c4 Compare October 26, 2020 10:58
@kschiffer kschiffer requested a review from bafonins October 26, 2020 10:58
@kschiffer kschiffer removed the needs/backport Needs to be backported to previous versions that are maintained label Oct 26, 2020
@kschiffer kschiffer merged commit d9fc633 into v3.10 Oct 26, 2020
@kschiffer kschiffer deleted the fix/3324-event-stream-pause branch October 26, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/console This is related to the Console documentation This involves writing user documentation technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix event selection in the Console
2 participants