-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix freezes and further improve performance of event views #3301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschiffer
added
c/console
This is related to the Console
performance
Something is slow or takes too much CPU/Memory/...
technical debt
Not necessarily broken, but could be done better/cleaner
ui/web
This is related to a web interface
needs/backport
Needs to be backported to previous versions that are maintained
labels
Sep 30, 2020
github-actions
bot
added
the
documentation
This involves writing user documentation
label
Sep 30, 2020
kschiffer
force-pushed
the
fix/2887-event-performance
branch
from
October 1, 2020 10:21
f88bf13
to
302502b
Compare
Closing to split up into individual PRs. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c/console
This is related to the Console
documentation
This involves writing user documentation
needs/backport
Needs to be backported to previous versions that are maintained
performance
Something is slow or takes too much CPU/Memory/...
technical debt
Not necessarily broken, but could be done better/cleaner
ui/web
This is related to a web interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes lags, freezes and improves the performance of the event views by introducing various performance optimizations.
Closes #2887
Changes
<Event />
component<SafeInspector.Light />
to avoid big overheads of the regular safe inspector when rendered inside eventsgetByPath()
object prop utility with vanilla implementation<DateFormat />
with simple vanilla implementationPureComponent
react-window
<SafeInspector />
Testing
Manual testing in staging environment and injected redux state
Regressions
This might introduce issues regarding
Notes for Reviewers
From my own profiling and testing, this improves the stability and speeds up the performance of the event view significantly. Regarding performance optimization there's obviously a never-ending room for further tweaks, though I think this is the best trade-off between reasonable performance optimization and avoiding adding too many obtrusive code changes.
Regarding 2000 event limit: this seemed like a sane limitation to me for now, at which the console still runs smoothly. We might want to fine-tune this value later when we have more feedback and metrics. Generally, it's important to establish for the user that the Console event view is not the correct place to source long-term event data.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.