Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stability and status communication of event views #3267

Merged
merged 3 commits into from
Sep 28, 2020

Conversation

kschiffer
Copy link
Contributor

@kschiffer kschiffer commented Sep 22, 2020

Summary

This PR improves the stability and error resilience of event related views and components in the Console. It will issue automatic reconnection events when the streams have been interrupted either periodically if a connection to the internet persists or triggered by the online event when the browser detected the system going offline. It also issues "synthetic"
status and info events that add situational awareness for the user.

Closes #2884

Screenshot

image

Changes

  • Update store logic to
    • Prevent crashing the whole view on any error
    • Perform automatic reconnects
      • either periodically (5s) if the browser is still online
      • or once when the internet connection is reestablished
    • Distinguish between planned, client initiated stream closings and unexpected stream disconnects from the remote side
    • Issue synthetic events for various situations (disconnect and reconnects, errors, event clearing)
    • Resolve a precision issue in the time comparison of events for sorting them chronologically

Testing

Manual testing.

Regressions

This PR might introduce issues related to

  • Correct display of events
  • Establishing or maintaining the stream connection

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added bug Something isn't working c/console This is related to the Console in progress We're working on it technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface labels Sep 22, 2020
@kschiffer kschiffer added this to the September 2020 milestone Sep 22, 2020
@kschiffer kschiffer self-assigned this Sep 22, 2020
@github-actions github-actions bot added the documentation This involves writing user documentation label Sep 22, 2020
@kschiffer kschiffer changed the title Improve error resilience of event streams in the Console Improve stability and status communication of event views Sep 22, 2020
@kschiffer kschiffer force-pushed the fix/2887-event-refactors branch from edd7d14 to 5bc32d7 Compare September 22, 2020 16:19
Base automatically changed from fix/2887-event-refactors to v3.9 September 22, 2020 17:25
@kschiffer kschiffer force-pushed the fix/2884-event-error-resilience branch from 0063db4 to 6a1cd74 Compare September 22, 2020 17:27
@kschiffer kschiffer marked this pull request as ready for review September 22, 2020 17:29
@kschiffer kschiffer removed the in progress We're working on it label Sep 23, 2020
@kschiffer kschiffer force-pushed the fix/2884-event-error-resilience branch from 6a1cd74 to d31e82b Compare September 28, 2020 18:52
@github-actions github-actions bot added c/network server This is related to the Network Server compat/api This could affect API compatibility compat/config This could affect Configuration compatibility compat/db This could affect Database compatibility dependencies Pull requests that update a dependency file labels Sep 28, 2020
@kschiffer kschiffer changed the base branch from v3.9 to v3.10 September 28, 2020 18:53
@kschiffer kschiffer removed c/network server This is related to the Network Server compat/api This could affect API compatibility compat/config This could affect Configuration compatibility compat/db This could affect Database compatibility dependencies Pull requests that update a dependency file labels Sep 28, 2020
@kschiffer kschiffer force-pushed the fix/2884-event-error-resilience branch from d31e82b to 516d152 Compare September 28, 2020 18:56
@kschiffer kschiffer merged commit 614daf1 into v3.10 Sep 28, 2020
@kschiffer kschiffer deleted the fix/2884-event-error-resilience branch September 28, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/console This is related to the Console documentation This involves writing user documentation technical debt Not necessarily broken, but could be done better/cleaner ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make event data views more resilient of errors
2 participants