Merge pull request #7337 from TheThingsNetwork/fix/dev-nonces-reuse-t…

…oo-small Fix reversed Join Server dev nonce metrics
TheThingsNetwork · Oct 15, 2024 · 4203826 · 4203826
2 parents b98a593 + 12629bd
commit 4203826
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,6 +20,7 @@ For details about compatibility between different releases, see the **Commitment
 ### Fixed
 
 - Potential leak of end devices of other (owned) applications in the top end devices panel in the application overview of the Console.
+- Fix reversed Join Server dev nonce metrics.
 
 ### Security
 

diff --git a/pkg/joinserver/observability.go b/pkg/joinserver/observability.go
@@ -130,9 +130,9 @@ func registerRejectJoin(ctx context.Context, req *ttnpb.JoinRequest, err error)
 }
 
 func registerDevNonceReuse(ctx context.Context, msg *ttnpb.JoinRequest) {
-	jsMetrics.devNonce.tooSmall.WithLabelValues(ctx, ttnpb.MACVersion_name[int32(msg.SelectedMacVersion)]).Inc()
+	jsMetrics.devNonce.reuse.WithLabelValues(ctx, ttnpb.MACVersion_name[int32(msg.SelectedMacVersion)]).Inc()
 }
 
 func registerDevNonceTooSmall(ctx context.Context, msg *ttnpb.JoinRequest) {
-	jsMetrics.devNonce.reuse.WithLabelValues(ctx, ttnpb.MACVersion_name[int32(msg.SelectedMacVersion)]).Inc()
+	jsMetrics.devNonce.tooSmall.WithLabelValues(ctx, ttnpb.MACVersion_name[int32(msg.SelectedMacVersion)]).Inc()
 }