Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use protoc-gen-validate fork only for generation #50

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Use protoc-gen-validate fork only for generation #50

merged 2 commits into from
Aug 8, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

References TheThingsIndustries/protoc-gen-validate#9

Changes

  • Use github.com/TheThingsIndustries/protoc-gen-validate for code generation.
  • Use github.com/envoyproxy/protoc-gen-validate for protobuf registration and definitions.
  • Update dependencies.

@adriansmares adriansmares self-assigned this Aug 8, 2023
johanstokking
johanstokking approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah easy, perfect, thanks

@adriansmares adriansmares merged commit 6ae0f18 into master Aug 8, 2023
1 check passed
@adriansmares adriansmares deleted the fix/use-fork-only-for-generation branch August 8, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstokking johanstokking johanstokking approved these changes

Assignees

@adriansmares adriansmares

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriansmares @johanstokking