Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add attributes to uplink message data format #1397

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

vlasebian
Copy link
Contributor

@vlasebian vlasebian commented Jan 16, 2025

Summary

References #7451 in thethingsnetwork/lorawan-stack.

Screenshots

Screenshot 2025-01-16 at 17 20 03 Screenshot 2025-01-16 at 17 20 08 Screenshot 2025-01-16 at 17 20 16 Screenshot 2025-01-16 at 17 20 24

Changes

  • Add attributes to uplink message data format

Notes for Reviewers

None.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

Copy link
Contributor

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new-in-version tag and set that to v3.34.0.

@vlasebian
Copy link
Contributor Author

I've added the tag near the new fields, but the formatting isn't looking good. The tag formatting conflicts with the code block:

Screenshot 2025-01-29 at 12 03 17 Screenshot 2025-01-29 at 12 05 38

Eventually I simply added a note at the beginning of the page prefixed with the tag:

Screenshot 2025-01-29 at 12 21 40

@vlasebian vlasebian requested a review from KrishnaIyer January 29, 2025 10:22
@vlasebian vlasebian merged commit a790856 into master Jan 29, 2025
1 check passed
@vlasebian vlasebian deleted the device-attributes branch January 29, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants