Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure documentation #1394

Merged
merged 32 commits into from
Jan 20, 2025
Merged

Restructure documentation #1394

merged 32 commits into from
Jan 20, 2025

Conversation

KrishnaIyer
Copy link
Contributor

@KrishnaIyer KrishnaIyer commented Jan 13, 2025

Summary

Restructure documentation.

Changes

  • 98% of the content is just updating links and aliases.

  • Update aliases. Missing aliases checked using the alias check tool:

go run util/check-aliases.go
Check 841 URLs for changes
Original: 841, Unchanged: 841, Aliased: 0, Missing: 0
  • Small content improvements where necessary.

Screenshots

Screen Shot 2025-01-16 at 16 30 04
Screen Shot 2025-01-16 at 16 30 06
Screen Shot 2025-01-16 at 16 30 10
Screen Shot 2025-01-16 at 16 30 13
Screen Shot 2025-01-16 at 16 30 15
Screen Shot 2025-01-16 at 16 30 24

Notes for Reviewers

To do

  • Self review
  • Fill content holes
  • Check that aliases are correct

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

@KrishnaIyer KrishnaIyer added this to the Jan 2025 milestone Jan 13, 2025
@KrishnaIyer KrishnaIyer self-assigned this Jan 13, 2025
doc/content/concepts/architecture/_index.md Outdated Show resolved Hide resolved
doc/content/concepts/architecture/_index.md Outdated Show resolved Hide resolved
doc/content/api/concepts/troubleshooting/_index.md Outdated Show resolved Hide resolved
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

Copy link
Contributor

@mjamescompton mjamescompton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, much prefer the new structure but we need to create 301 redirects for every URL change so that all our search results to go to 404s.

This a pain to do with hugo and github pages as we don't have something like nginx where we can write this.

This look like the best bet. I'm just testing it now
Screenshot 2025-01-17 at 10 56 55

@KrishnaIyer
Copy link
Contributor Author

Looks great, much prefer the new structure but we need to create 301 redirects for every URL change so that all our search results to go to 404s.

This a pain to do with hugo and github pages as we don't have something like nginx where we can write this.

Hmm, I don't understand. We already use aliases and that's how we've always handled moving pages.

@mjamescompton
Copy link
Contributor

@KrishnaIyer Sorry looks like they are there just did not work the first time I ran make server

@mjamescompton
Copy link
Contributor

And this was the first one I checked doc/content/hardware/gateways/_index.md which alias must be automatic somehow

@KrishnaIyer KrishnaIyer merged commit ab36344 into master Jan 20, 2025
1 check passed
@KrishnaIyer KrishnaIyer deleted the restructure/docs branch January 20, 2025 13:54
@HeadBoffin
Copy link

The sudden loss of the very comprehensive reference section linked on the home page that now appears scattered across the Sandbox, Cloud & Enterprise is meh boarding on WTF. I'll get used to it eventually but there will have to be a mandatory sulking period.

@johanstokking
Copy link
Member

@HeadBoffin the Reference section became a random dump place of documentation that was relevant but we couldn't naturally fit it into good section. So we reorganized it so that we don't need to have a random dump place. What I do understand is that it would be nice to have a site map like overview, is that what you mean?

@HeadBoffin
Copy link

I really didn't see it as a random dumping ground - most of the time the stuff I needed was in the reference section - particularly the CLI ref - so I'm re-orientating myself but struggling somewhat as I'm not sure if the search has indexed all the pages as I've got lost a couple of times in the last week trying to find some pages.

A site-map couldn't hurt if it can be auto-generated. I've got some training notes I'll need to update for next week, I can use that as an opportunity to evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants