Ignore missing command if ensure is not set to present
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in case ensure is absent, there is no need to define the `command` parameter. This restores backward compatibility with the 1.x version of the module. in case `ensure` is `present`, the a failure will be raised
TheMeier
changed the title
ensure is not set to presentensure is not set to present
|
Nice, way more simple and elegant than #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre 2.0.0 version was happily ignoring if the
commandparameter was not set, in the case that theensureparameter was set toabsent.Although I tried my best to make the 2.0.0 version as backward compatible as possible I did overlook this scenario.
This change will restore the previous behaviour in this case.
Also with the release of
puppet-systemdthe puppet 8 check where re-enabled.