-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to 1.19.2 #151
Port to 1.19.2 #151
Conversation
Note: Build will fail until TheCBProject/CodeChickenLib#443 is merged and dependency version in here is bumped |
Is this still valid? I bumped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, few comments.
We should also cleanup all deprecations from #149 in here.
src/main/java/codechicken/microblock/client/MicroblockRender.java
Outdated
Show resolved
Hide resolved
src/main/java/codechicken/multipart/api/part/ModelRenderPart.java
Outdated
Show resolved
Hide resolved
src/main/java/codechicken/multipart/api/part/render/PartBakedModelRenderer.java
Outdated
Show resolved
Hide resolved
153be11
to
c1513e7
Compare
All requested changes applied. Will do final testing on a clean client/server installation and merge tonight. |
I think there is some further cleanup available here, but not a blocker. We should be able to use |
Note: Based on #149. Do not merge until that is cleaned up, merged, and this branch is rebased.
Everything appears to be fully functional only significant change was how render layers are handled now for
PartBakedModelRenderer
and Microblock parts. Instead of asking the part itself if it can render in a specific layer, that decision is now made directly by theBakedModel
itself.