Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to 1.19.2 #151

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Port to 1.19.2 #151

merged 1 commit into from
Nov 5, 2023

Conversation

MrTJP
Copy link
Member

@MrTJP MrTJP commented Jul 10, 2023

Note: Based on #149. Do not merge until that is cleaned up, merged, and this branch is rebased.

Everything appears to be fully functional only significant change was how render layers are handled now for PartBakedModelRenderer and Microblock parts. Instead of asking the part itself if it can render in a specific layer, that decision is now made directly by the BakedModel itself.

@MrTJP MrTJP changed the base branch from master to patch-0624 July 10, 2023 17:27
@MrTJP
Copy link
Member Author

MrTJP commented Jul 10, 2023

Note: Build will fail until TheCBProject/CodeChickenLib#443 is merged and dependency version in here is bumped

@kyle1elyk
Copy link

Note: Build will fail until TheCBProject/CodeChickenLib#443 is merged and dependency version in here is bumped

Is this still valid? I bumped ccl_version in my local to ccl_version=4.3.2.+ and the build passed/jar generated.

Copy link
Member

@covers1624 covers1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few comments.

We should also cleanup all deprecations from #149 in here.

@MrTJP MrTJP changed the base branch from patch-0624 to master November 3, 2023 04:03
@MrTJP MrTJP force-pushed the feature/1.19.2 branch 2 times, most recently from 153be11 to c1513e7 Compare November 3, 2023 11:30
@MrTJP
Copy link
Member Author

MrTJP commented Nov 4, 2023

All requested changes applied. Will do final testing on a clean client/server installation and merge tonight.

@covers1624
Copy link
Member

I think there is some further cleanup available here, but not a blocker.

We should be able to use DeferredRegister to submit things under the vanilla namespace. Default micro materials and microblocks. In the past this was not possible and nuking/resetting the mod loading context was required.

@MrTJP MrTJP merged commit 42d59a6 into master Nov 5, 2023
@MrTJP MrTJP deleted the feature/1.19.2 branch November 5, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants