Talk about "application", not "AppImage" #184
Conversation
probonopd
commented
Jul 3, 2019
•
probonopd
commented
- Should fix Extraneous launcher entries in KDE Plasma #180
- Is more in line with https://github.com/AppImage/AppImageKit/wiki/Design-principles#end-user-experience
| @@ -541,7 +541,7 @@ bool installDesktopFileAndIcons(const QString& pathToAppImage, bool resolveColli | |||
| } | |||
| } | |||
|
|
|||
| #ifdef ENABLE_UPDATE_HELPER | |||
| #ifdef ENABLE_+_HELPER | |||
There was a problem hiding this comment.
That breaks things completely. Might have been an accidental change.
There was a problem hiding this comment.
Did I change this? Must have been inadvertently. I just want "AppImage" to be replaced with "application".
|
I don't like this change. We must differentiate between "system wide apps" and "user-local AppImages". The desktop action is missing for regular system apps. To not confuse people, the term AppImage is better here. |
|
Please reconsider if you want this tool to replace any of my tools. |
|
Feel free to use the AppImage icon if you think this makes this change more feasible. |
|
That might be a better UX then. When the AppImage icon is used, it gets pretty clear to a user that these are AppImage only features. That's IMO a good thing, to be honest. It advertises this "if you use AppImage, your life becomes easier" thing we're working on, as other applications don't have such an easy UX. That's the thing I want to highlight. |
|
Hence, please reopen. |
