Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/fix failing tests #1394

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Bugfix/fix failing tests #1394

merged 3 commits into from
Oct 2, 2023

Conversation

defaude
Copy link
Contributor

@defaude defaude commented Oct 1, 2023

Open in Gitpod know more

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

defaude and others added 3 commits October 1, 2023 19:05
@defaude
test: remove ValidateUrl.test.js
5000ad0 
The code was removed with ecac786 but the test was left here (and has been failing since then, obviously 🤣)
@defaude
test: remove conflicting test case
ba6920b 
There is another test case that explicitly expects the `null` result when the input array only contains one element.
Updated Documentation in README.md
7f3debc
@raklaptudirm raklaptudirm merged commit b783612 into TheAlgorithms:master Oct 2, 2023
2 checks passed
@appgurueu appgurueu mentioned this pull request Oct 2, 2023
Closed
11 tasks
@defaude defaude deleted the bugfix/fix-failing-tests branch October 2, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@defaude @appgurueu @raklaptudirm