Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BinaryToText.js and BinaryToText.test.js #1384

Closed
wants to merge 4 commits into from
Closed

Added BinaryToText.js and BinaryToText.test.js #1384

wants to merge 4 commits into from

Conversation

User-DK
Copy link

@User-DK User-DK commented Oct 1, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This effectively boils down to str.split(" ").map(x => String.fromCharCode(parseInt(x, 2))).join(" "). Please write it roughly like this and rename the function to a more fitting name. A single test case suffices, the second test case is not needed.

@User-DK
Copy link
Author

User-DK commented Oct 3, 2023

Hello sir, I made the necessary changes

@@ -0,0 +1,12 @@
// How to Convert Binary to Text
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This explanation is unnecessary, the code is readable as-is. If anything, add a proper JSDoc comment. Also, format this properly please.

@appgurueu
Copy link
Collaborator

Sorry, but we have decided that this (and PRs like this in general) don't add enough value to warrant inclusion; the split - transform - join pattern for linear time string manipulation is demonstrated elsewhere already. In the future, if in doubt whether something is algorithmically interesting enough to warrant inclusion, please open an issue.

@appgurueu appgurueu closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants