Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added contributor graph to the readme #1367

Merged
merged 1 commit into from
Sep 23, 2023
Merged

added contributor graph to the readme #1367

merged 1 commit into from
Sep 23, 2023

Conversation

dev-madhurendra
Copy link
Contributor

@dev-madhurendra dev-madhurendra commented Sep 22, 2023

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this in the Readme? An excerpt of it is already visible in the sidebar, and users can click on that if they want to see more.

@dev-madhurendra
Copy link
Contributor Author

Why do we need this in the Readme? An excerpt of it is already visible in the sidebar, and users can click on that if they want to see more.

Yeah, You are right but at left side we can see only few things and in readme we can see all the contributors. It is a way of thanking all the contributors.

@appgurueu
Copy link
Collaborator

I'm neutral on this.

@raklaptudirm raklaptudirm merged commit 394483b into TheAlgorithms:master Sep 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants