Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added an algo for reversing a number and also added test cases which … #1365

Closed
wants to merge 3 commits into from
Closed

added an algo for reversing a number and also added test cases which … #1365

wants to merge 3 commits into from

Conversation

dev-madhurendra
Copy link
Contributor

@dev-madhurendra dev-madhurendra commented Sep 22, 2023

…was not there previously

Open in Gitpod know more

Describe your change:

I added an algorithm which finds reverse of a number in another way by just converting it to string and then reversing it.
I also added test cases for it which was not there.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[-9876, -6789],
[0, 0],
[7, 7]
])('should reverse a positive number', (value, expected) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add the negative case to the test cases.

[9876, 6789],
[0, 0],
[7, 7]
])('should reverse a positive number', (value, expected) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change the description of this to use a format string.

Maths/ReverseNumber.js Outdated Show resolved Hide resolved
Maths/ReverseNumber.js Outdated Show resolved Hide resolved
Maths/ReverseNumber.js Outdated Show resolved Hide resolved
@dev-madhurendra dev-madhurendra closed this by deleting the head repository Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants