-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added an algo for reversing a number and also added test cases which … #1365
Closed
dev-madhurendra
wants to merge
3
commits into
TheAlgorithms:master
from
dev-madhurendra:reverse-number-simple-method
Closed
added an algo for reversing a number and also added test cases which … #1365
dev-madhurendra
wants to merge
3
commits into
TheAlgorithms:master
from
dev-madhurendra:reverse-number-simple-method
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was not there previously
dev-madhurendra
requested review from
raklaptudirm and
appgurueu
as code owners
September 22, 2023 10:01
appgurueu
reviewed
Sep 22, 2023
[-9876, -6789], | ||
[0, 0], | ||
[7, 7] | ||
])('should reverse a positive number', (value, expected) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add the negative case to the test cases.
appgurueu
reviewed
Sep 22, 2023
[9876, 6789], | ||
[0, 0], | ||
[7, 7] | ||
])('should reverse a positive number', (value, expected) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd change the description of this to use a format string.
appgurueu
reviewed
Sep 22, 2023
appgurueu
reviewed
Sep 22, 2023
appgurueu
reviewed
Sep 22, 2023
appgurueu
reviewed
Sep 22, 2023
appgurueu
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…was not there previously
know more
Describe your change:
I added an algorithm which finds reverse of a number in another way by just converting it to string and then reversing it.
I also added test cases for it which was not there.
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.