rsz: hold check dont touch instances #6633
Draft
+162
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Gadfort <[email protected]>
Signed-off-by: Peter Gadfort <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
reviewed
Feb 3, 2025
| @@ -440,7 +442,16 @@ void RepairHold::repairEndHold(Vertex* end_vertex, | |||
| } | |||
| } | |||
| } | |||
| if (!load_pins.empty()) { | |||
| // check for dont touch loads | |||
There was a problem hiding this comment.
Rather than prevent buffering if there is a dont-touch fanout you can just leave the fanouts attached and add the new net to the buffer's input. I believe RepairDesign::makeRepeater does this and perhaps could be generalized?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds: