Add helper for making EC key from components #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First pass on mobile this looks absolutely stellar 👌 🙌 |
|
I would really appreciate to see this functionality in the main branch 😍 |
prince-chrismc
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Even the docs look good 👏
If I have to be picky, an example and the openssl command to generate the test certificate would take this above 100%
I believe the correct one for this curve is
➜ /tmp openssl ecparam -genkey -name secp384r1 -noout -out private-key.pem
➜ /tmp openssl ec -in private-key.pem -pubout -out public-key.pem
read EC key
writing EC key
➜ /tmp cat public-key.pem
-----BEGIN PUBLIC KEY-----
MHYwEAYHKoZIzj0CAQYFK4EEACIDYgAEmMgWcIvCrgWF9zvYy5y5fO8EQutEYzJl
K6DF8S7DN/RUsorSJdBMvJ8l66Crlq1mSWWFztseK6URXfUJSK1vj2dE5QoUkaxh
S6WqXuZ2jT0dHjJxDAZc7M2e+EImdDU5
-----END PUBLIC KEY-----
the curve names are a nightmare 🙊
| std::string group = helper::curve2group(curve, ec); | ||
| if (ec) return {}; | ||
|
|
||
| // https://github.com/openssl/openssl/issues/16270#issuecomment-895734092 |
|
@tomhughes This is one of the best contributions a maintainer can hope for so it's super appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parallels the work done in #307 for EC keys by providing a helper to construct them from their components which is useful when the provider does not publish an
x5cversion of the key.