fix(scrollbar): fix scrollbar background opacity #5462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomJGooding
changed the title
|
Yeah, this looks like the right fix. Could you humor me and make a small optimization. If the scrollbar background has zero alpha, then don't call the slightly expensive |
|
@willmcgugan Glad I was on the right track but good point about the optimisation. Updated in a35d48a. |
willmcgugan
reviewed
Jan 8, 2025
|
Gracias |
|
Thanks @TomJGooding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5458.
This assumes that when the scrollbar background has opacity, it should blend with the 'base' background and not the background of its widget.
Please review the following checklist.