Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue where the public dataset search result page displays public workflows after refreshing #3230

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

GspikeHalo
Copy link
Collaborator

Purpose:

Currently, after refreshing the public dataset search result page, public workflow search results appear. The issue occurs because the URL check and type update are only triggered when the NavigationEnd event is detected. However, when the page is refreshed, it retains the default type, which is the workflow search results.

Changes:

Directly check the URL and update the type in OnInit.

Demos:

Before:
before refreshing:
image

after refreshing:
image

After:
before refreshing:
image

after refreshing:
image

Copy link
Collaborator

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GspikeHalo GspikeHalo merged commit d349903 into master Jan 27, 2025
8 checks passed
@GspikeHalo GspikeHalo deleted the fix-hub-search-result branch January 27, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants