Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSV File Scan Operator #3217

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix CSV File Scan Operator #3217

wants to merge 6 commits into from

Conversation

MiuMiuMiue
Copy link
Collaborator

@MiuMiuMiue MiuMiuMiue commented Jan 16, 2025 •
edited
Loading

Fix the issue #3055 that CSV Scan an empty file would result in error.

@MiuMiuMiue MiuMiuMiue self-assigned this Jan 16, 2025
@MiuMiuMiue MiuMiuMiue changed the title Execute CSV File Scan operator when csv file is empty Fix CSV File Scan Operator Jan 16, 2025
@MiuMiuMiue MiuMiuMiue added the bug label Jan 16, 2025
@MiuMiuMiue MiuMiuMiue requested a review from bobbai00 January 16, 2025 06:27
bobbai00
bobbai00 reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please simplify the code as suggested

...operator/src/main/scala/edu/uci/ics/amber/operator/source/scan/csv/CSVScanSourceOpDesc.scala Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbai00 bobbai00 bobbai00 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@MiuMiuMiue MiuMiuMiue

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiuMiuMiue @bobbai00