Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DatasetResource and DatasetAccessResource #3210

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

bobbai00
Copy link
Collaborator

This PR refactors the codes style of the DatasetResource and DatasetAccessResource.

Specifically, the refactoring principles are:

  1. Move all the function definition in object, that are only being used within the class, to the class
  2. Uniform the way of interacting with jooq: use either jooq raw query, or Dao, not both.
  3. Flatten single-kv-pair case classes.
  4. Flatten the single-line function.

@bobbai00 bobbai00 requested a review from aglinxinyuan January 14, 2025 02:34
@bobbai00 bobbai00 self-assigned this Jan 14, 2025
@bobbai00 bobbai00 added the refactoring Refactor the code label Jan 14, 2025
Copy link
Collaborator

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We had a offline discussion regarding the changes.

@bobbai00 bobbai00 merged commit 00aa822 into master Jan 14, 2025
8 checks passed
@bobbai00 bobbai00 deleted the jiadong-refactor-dataset branch January 14, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants