Fix "NullpointerException" when an operator is created initially #3193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
reviewed
Feb 3, 2025
| @@ -6,12 +6,13 @@ | |||
|
|
|||
| public class SortCriteriaUnit { | |||
|
|
|||
| @JsonProperty(value = "attribute", required = true) | |||
There was a problem hiding this comment.
Is this change necessary?
| @JsonSchemaTitle("Font Size") | ||
| @JsonPropertyDescription("Font size of the Figure Factory Table") | ||
| var fontSize: String = "12" | ||
|
|
||
| @JsonProperty(required = false) | ||
| @JsonProperty(required = false, defaultValue = "#000000") |
There was a problem hiding this comment.
why does the default value need to be written twice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issues described in #3191 and addresses all related Python visualization operators. The fix involves removing unnecessary assertions and assigning default values to fields that were previously null.
The root cause of the issue was the early Python code generation during the transformation from a logical plan to a physical plan. This behavior is expected due to the decision to push schema propagation to the physical plan layer.