-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public datasets under "Hub" #3129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom downloading. Prevent users on the hub interface from modifying the publish status. Update the user dataset interface to display only datasets with direct permissions.
GspikeHalo
changed the base branch from
master
to
update-dataset-workflow-table
December 18, 2024 05:55
GspikeHalo
changed the base branch from
update-dataset-workflow-table
to
master
December 18, 2024 05:55
Please modify the description to make it clear that the behaviors of Public Datasets are similar to those of Public Workflows. |
GspikeHalo
changed the title
Add public datasets under "Community"
Add public datasets under "Hub"
Jan 17, 2025
aglinxinyuan
requested changes
Jan 19, 2025
core/gui/src/app/hub/component/dataset/hub-dataset.component.ts
Outdated
Show resolved
Hide resolved
core/gui/src/app/hub/component/dataset/search/hub-dataset-search.component.ts
Outdated
Show resolved
Hide resolved
aglinxinyuan
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
core/amber/src/main/scala/edu/uci/ics/texera/web/resource/dashboard/DashboardResource.scala
Show resolved
Hide resolved
.../src/main/scala/edu/uci/ics/texera/web/resource/dashboard/user/dataset/DatasetResource.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Added a new interface for public datasets, allowing non-logged-in users to view datasets shared by others. The behavior of public datasets aligns with that of public workflows, ensuring consistent access and interaction with public resources.
Changes:
functionality and does not display the publish switch.
Demos:
Before:
Left sidebar:
After:
Left sidebar:
Public Dataset Interface Before Login:
Public Dataset Interface After Login:
Non-logged-in user clicking any dataset:
Logged-in user without direct permissions clicking any dataset:
Logged-in user with direct permissions clicking any dataset: