Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public datasets under "Hub" #3129

Merged
merged 39 commits into from
Jan 22, 2025
Merged

Add public datasets under "Hub" #3129

merged 39 commits into from
Jan 22, 2025

Conversation

GspikeHalo
Copy link
Collaborator

@GspikeHalo GspikeHalo commented Nov 30, 2024

Purpose:

Added a new interface for public datasets, allowing non-logged-in users to view datasets shared by others. The behavior of public datasets aligns with that of public workflows, ensuring consistent access and interaction with public resources.

Changes:

  1. Added "Hub Dataset" to the left sidebar. Clicking on it will display public datasets.
  2. Updated the list item behavior: When a user clicks a list item of type "dataset," different navigation actions are taken depending on the situation:
    • If the user is not logged in, they will always be redirected to the Hub Dataset page. This page disables the download
      functionality and does not display the publish switch.
    • If the user is logged in but lacks direct access permissions (e.g., read or write), they will still be redirected to the Hub Dataset page.
    • If the user is logged in and has read or write permissions, they will be redirected to the User Dataset page, which is the original dataset page we had.

Demos:

Before:
Left sidebar:
image

After:
Left sidebar:
image

Public Dataset Interface Before Login:
image

Public Dataset Interface After Login:
image

Non-logged-in user clicking any dataset:
image

Logged-in user without direct permissions clicking any dataset:
image

Logged-in user with direct permissions clicking any dataset:
image

@GspikeHalo GspikeHalo marked this pull request as ready for review December 18, 2024 03:55
@GspikeHalo GspikeHalo changed the base branch from master to update-dataset-workflow-table December 18, 2024 05:55
@GspikeHalo GspikeHalo changed the base branch from update-dataset-workflow-table to master December 18, 2024 05:55
@GspikeHalo GspikeHalo requested a review from chenlica January 11, 2025 22:15
@chenlica chenlica changed the title Add public dataset Add public datasets under "Community" Jan 12, 2025
@chenlica
Copy link
Collaborator

Please modify the description to make it clear that the behaviors of Public Datasets are similar to those of Public Workflows.

@GspikeHalo GspikeHalo marked this pull request as draft January 17, 2025 05:01
@GspikeHalo GspikeHalo changed the title Add public datasets under "Community" Add public datasets under "Hub" Jan 17, 2025
@GspikeHalo GspikeHalo marked this pull request as ready for review January 17, 2025 09:07
Copy link
Collaborator

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GspikeHalo GspikeHalo merged commit 460e078 into master Jan 22, 2025
8 checks passed
@GspikeHalo GspikeHalo deleted the add-public-dataset branch January 22, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants