Introduce IF operator #3090
Merged
Introduce IF operator #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...scala/edu/uci/ics/texera/workflow/operators/controlBlock/ifStatement/IfStatementOpDesc.scala
Outdated
Show resolved
Hide resolved
...scala/edu/uci/ics/texera/workflow/operators/controlBlock/ifStatement/IfStatementOpExec.scala
Outdated
Show resolved
Hide resolved
...scala/edu/uci/ics/texera/workflow/operators/controlBlock/ifStatement/IfStatementOpDesc.scala
Outdated
Show resolved
Hide resolved
Yicong-Huang
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Left some comments. In general:
- don't use
statement. there is no statement in workflows/operators. note for the terminology. we are borrowing the "if statement" concept from PL, but don't use the name in our context. - note for the naming conversions.
- pleases add more documentations.
...scala/edu/uci/ics/texera/workflow/operators/controlBlock/ifStatement/IfStatementOpDesc.scala
Outdated
Show resolved
Hide resolved
...scala/edu/uci/ics/texera/workflow/operators/controlBlock/ifStatement/IfStatementOpDesc.scala
Outdated
Show resolved
Hide resolved
...scala/edu/uci/ics/texera/workflow/operators/controlBlock/ifStatement/IfStatementOpDesc.scala
Outdated
Show resolved
Hide resolved
...scala/edu/uci/ics/texera/workflow/operators/controlBlock/ifStatement/IfStatementOpExec.scala
Outdated
Show resolved
Hide resolved
...scala/edu/uci/ics/texera/workflow/operators/controlBlock/ifStatement/IfStatementOpExec.scala
Outdated
Show resolved
Hide resolved
...src/main/scala/edu/uci/ics/texera/workflow/operators/controlBlock/ifStatement/IfOpExec.scala
Outdated
Show resolved
Hide resolved
Yicong-Huang
approved these changes
Jan 8, 2025
core/workflow-operator/src/main/scala/edu/uci/ics/amber/operator/ifStatement/IfOpDesc.scala
Outdated
Show resolved
Hide resolved
core/workflow-operator/src/main/scala/edu/uci/ics/amber/operator/ifStatement/IfOpDesc.scala
Outdated
Show resolved
Hide resolved
core/workflow-operator/src/main/scala/edu/uci/ics/amber/operator/ifStatement/IfOpDesc.scala
Outdated
Show resolved
Hide resolved
|
Tested with latest master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IFoperator evaluates a condition against a specified state variable and routes the input data to either theTrueorFalsebranch accordingly. The condition port accepts a state variable, and users can define the name of the state variable to be evaluated by theIFoperator.Note: The Date to State operator will be introduced in a separate PR.