-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch swipe tutorial #1201
Open
NyakoFox
wants to merge
33
commits into
TerryCavanagh:master
Choose a base branch
from
NyakoFox:touch-swipe-tutorial
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Touch swipe tutorial #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds virtual buttons on-screen to let you navigate through menus, and play the game.
Touch input automatically "disables" when you press a key on your keyboard. The back button on Android counts as a key press, so let's just ignore it.
For some reason, the code that handled button presses for the ingame menu checked the confirm button in the wrong places.
Basically, when you save and quit, if you have a save, it attempts to return to the `play` menu. Unfortunately for us, if you don't have a save first, that menu never existed. You went directly from `mainmenu` to the gameplay state. Since `play` never existed, the code didn't have any menu to return to, so no buttons got created. My fix is simple: if the menu isn't found, just make it.
The current mobile version of VVVVVV has three movement types: swipe, d-pad and sides. Swipe is the default, but my PRs have only implemented d-pad. This commit adds swipe and adds it as the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR implements the touch swipe tutorial from the current mobile version.
Depends on #1172.
Legal Stuff:
By submitting this pull request, I confirm that...
CONTRIBUTORS
file and the "GitHub Friends"section of the credits for all of said releases, but will NOT be compensated
for these changes unless there is a prior written agreement