test: ChartItem fixes #7420
Open
test: ChartItem fixes #7420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The annotation is not required.
This reveals that there are missing fields in the chartItem, so add in the missing fields.
pjonsson
commented
Dec 26, 2024
| @@ -18,11 +24,15 @@ describe("MomentPointsChart", function () { | |||
| { x: new Date("2020-05-29"), y: 0.5 }, | |||
| { x: new Date("2020-05-30"), y: 0.5 } | |||
| ], | |||
| domain: { x: [new Date("2020-05-25"), new Date("2020-05-30")], y: [0, 10] }, | |||
There was a problem hiding this comment.
I assume the domain relates to the points. I don't know if domain can contain dates, but nothing complains when I put them there, so I did.
I took the other values from one of the chartItems in BottomDockChartSpec.tsx.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Removes a few casts from one test, and adds a type annotation + missing fields to another test.
Test me
Test only changes.
Checklist
doc/.