Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): add covalent theming to angular code editor #2241

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

bsahitya
Copy link
Collaborator

@bsahitya bsahitya commented Sep 6, 2024

Description

Add covalent themes to angular code editor

What's included?

  • Add cv-light and cv-dark themes to angular-code-editor component

Test Steps

  • npx nx run docs-app:serve
  • Navigate to Components -> Examples -> Code Editor with Monaco
  • Change the theme to Covalent Light or Covalent Dark

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker
Screenshot 2024-09-06 at 10 24 26 AM Screenshot 2024-09-06 at 10 24 41 AM

@owilliams320 owilliams320 merged commit 5ed320e into main Sep 6, 2024
7 checks passed
@owilliams320 owilliams320 deleted the fix/angular-code-editor-theme branch September 6, 2024 17:49
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 8.20.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants