Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notebook-cell): add code editor and notebook cell components #2220

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

bsahitya
Copy link
Collaborator

Description

  • Notebook cell component: Figma
  • Code editor component - extends the monaco editor
  • Initial theming for the code editor

What's included?

  • Notebook cell web component
  • Code editor web component
  • Predefined themes for coed editor - cv-light, cv-dark

Test Steps

  • npm run storybook
  • Open code editor, notebook cell components
  • Test the functionality by changing the props

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

notebook-cell

owilliams320
owilliams320 previously approved these changes Aug 13, 2024
libs/components/src/select/select.scss Show resolved Hide resolved
Copy link
Collaborator

@owilliams320 owilliams320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@owilliams320 owilliams320 merged commit 69bcea9 into main Aug 13, 2024
7 checks passed
@owilliams320 owilliams320 deleted the feat/notebook-cell branch August 13, 2024 21:52
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 8.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants