Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Menlo font to code snippet and highlight components #2115

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

bsahitya
Copy link
Collaborator

@bsahitya bsahitya commented Mar 8, 2024

Description

Add support for Menlo font for coded text in components.

Closes #2080

What's included?

  • Code snippet, Highlight and Code editor components support Menlo

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.

Screenshots

Code Snippet Component

Screenshot 2024-03-11 at 9 51 19 AM

Syntax Highlight

Screenshot 2024-03-11 at 9 53 07 AM

Code Editor

Screenshot 2024-03-11 at 9 53 39 AM

Copy link
Collaborator

@owilliams320 owilliams320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@owilliams320 owilliams320 merged commit 6bcd603 into main Mar 11, 2024
7 checks passed
@owilliams320 owilliams320 deleted the fix/code-font-menlo branch March 11, 2024 15:51
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 8.5.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "Menlo" font for code snippets.
2 participants