Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): separating theme into light/dark files #2106

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

owilliams320
Copy link
Collaborator

@owilliams320 owilliams320 commented Feb 23, 2024

Description

Adding light / dark theme files included from web components package

What's included?

  • scss build task for light/dark theme for the web components build
  • users can now reference seperate theme files at @covalent/components/theme/(light|dark)-theme.css
  • angular package should now be re-including the prebuilt themes at @covalent/core/prebuilt and @covalent/core/common

Test Steps

  • npm run components build-scss
  • then see the result in dist/libs/components/theme

@owilliams320 owilliams320 changed the title feat(components): seperating theme into light/dark files feat(components): separating theme into light/dark files Feb 23, 2024
@owilliams320 owilliams320 merged commit 9c2c486 into main Feb 26, 2024
7 checks passed
@owilliams320 owilliams320 deleted the feat/knapsack-asset-themes branch February 26, 2024 22:22
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 8.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant