Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): icon-radio rendering #2041

Merged
merged 1 commit into from
Jul 24, 2023
Merged

fix(components): icon-radio rendering #2041

merged 1 commit into from
Jul 24, 2023

Conversation

owilliams320
Copy link
Collaborator

Description

Fixing the javascript error caused by the icon-radio component

What's included?

  • using the render method from the base radio class
  • adjusting css to overwrite the base mdc styles

Test Steps

  • npm run storybook
  • then once the browser opens navigate to the icon radio story
  • finally test the icon radio for errors

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

Copy link
Contributor

@DersJ DersJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@owilliams320 owilliams320 merged commit 9e0da07 into main Jul 24, 2023
7 checks passed
@owilliams320 owilliams320 deleted the fix/icon-radio branch July 24, 2023 15:24
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants