feat: webconsole relay优化 #3593
Open
feat: webconsole relay优化 #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifooth
reviewed
Oct 25, 2024
| return nil | ||
| } | ||
|
|
||
| timer := time.NewTicker(time.Second * 30) |
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| // 获取退出信号, 删除一次 |
|
|
||
| folderNames, err := u.storage.ListFolders(ctx, "") | ||
| if err != nil { | ||
| blog.Errorf("list folders failed, err: %s", err) |
There was a problem hiding this comment.
错误和日志记录一个就好， 调用函数入口已经记录，可以返回fmt.Errorf("list folders: %w", err), 下同
https://tonybai.com/2024/04/14/either-return-error-or-log-them-do-not-do-both/
| v = strings.Trim(v, "/") | ||
| date, err := time.Parse(time.DateOnly, v) | ||
| if err != nil { | ||
| continue |
There was a problem hiding this comment.
这里如果目录不合法，效果是直接隐藏了， 直接按0值处理（相同的日志按字符串排序）
| for _, v := range folderNames { | ||
| v = strings.Trim(v, "/") | ||
| date, err := time.Parse(dateTimeFormat, v) | ||
| if err != nil { |
| DataDir string `yaml:"data_dir"` // 格式如 ./data | ||
| Enabled bool `yaml:"enabled"` | ||
| DataDir string `yaml:"data_dir"` // 格式如 ./data | ||
| ReserveDay int `yaml:"reserve_day"` |
| @@ -185,6 +185,29 @@ func (b *bkrepoStorage) ListFolders(ctx context.Context, folderName string) ([]s | |||
| return folders, nil | |||
| } | |||
|
|
|||
| // DeleteFolders delete of folders under current bkRepo folder | |||
|
|
||
| var expireFolders []string | ||
| reserveDay := time.Duration(config.G.Audit.ReserveDay) | ||
| if reserveDay == 0 { |
There was a problem hiding this comment.
0应该是不删除， 默认30天在配置文件中， 记得输出 ./bcs-webconsole -o yaml > etc/config.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: webconsole relay优化