Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save disk read bandwidth for compaction by reading right types of keys #235

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

leonliao
Copy link

Description

When blobdb enabled, avoid consuming read disk bandwidth by just checking keys of RT_DATA_META type.
It solves #234

Motivation and Context

The read bandwidth is too high when enabling the RocksDB's blobdb feature.
And it is found out that it is partly because reading the blob values of large hash field value(> min_blob_size).
And TTL for keys is only saved in RT_DATA_META type keys.
This PR only reads blob values of RT_DATA_META type, saving read IO.

How Has This Been Tested?

Tested in lab, the bandwidth is significantly lower when using hash data types with large hash values.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Code follows the code style of this project.
  • Change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant