Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/waterfall view bug #4063

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Fix/waterfall view bug #4063

merged 3 commits into from
Oct 15, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@siguangli siguangli requested a review from iPel as a code owner October 13, 2024 13:16
@github-actions github-actions bot added renderer: native size: s Denotes a PR that changes 10-99 lines labels Oct 13, 2024
@tencent-adm
Copy link
Member

tencent-adm commented Oct 13, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ siguangli
❌ siguangli2018
You have signed the CLA already but the status is still pending? Let us recheck it.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Oct 13, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

rockyIsRK
rockyIsRK reviewed Oct 14, 2024
View reviewed changes
renderer/native/android/src/main/java/com/tencent/mtt/hippy/views/modal/HippyModalHostView.java
mDialogRootView.removeView(child);
}

public int getModalChildCount() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider adding a comment to explain the method

rockyIsRK
rockyIsRK previously approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@rockyIsRK rockyIsRK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

iPel
iPel approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@iPel iPel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hippy-service Hippy Service
Copy link

hippy-service bot commented Oct 14, 2024

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@siguangli siguangli merged commit 53c8a09 into Tencent:main Oct 15, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPel iPel iPel approved these changes

@rockyIsRK rockyIsRK rockyIsRK left review comments

Assignees
No one assigned
Labels
renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siguangli @tencent-adm @iPel @rockyIsRK @siguangli2018