fix(android): lru cache is thread safe

Tencent · Jul 22, 2024 · dee2a2b · dee2a2b
1 parent 8922706
commit dee2a2b
Showing 1 changed file with 12 additions and 21 deletions.
diff --git a/modules/android/pool/src/main/java/com/openhippy/pool/ImageDataPool.java b/modules/android/pool/src/main/java/com/openhippy/pool/ImageDataPool.java
@@ -23,7 +23,6 @@
 public class ImageDataPool extends BasePool<ImageDataKey, ImageRecycleObject> {
 
     private static final int DEFAULT_IMAGE_POOL_SIZE = 16;
-    private final Object mLock = new Object();
     private LruCache<ImageDataKey, ImageRecycleObject> mPools;
 
     public ImageDataPool() {
@@ -51,17 +50,15 @@ protected void entryRemoved(boolean evicted, @NonNull ImageDataKey key,
     @Override
     @Nullable
     public ImageRecycleObject acquire(@NonNull ImageDataKey key) {
-        synchronized (mLock) {
-            ImageRecycleObject data = mPools.get(key);
-            if (data != null && data.isScraped()) {
-                // Bitmap may have been recycled, must be removed from the cache and not
-                // returned to the component.
-                mPools.remove(key);
-                data.evicted();
-                return null;
-            }
-            return data;
+        ImageRecycleObject data = mPools.get(key);
+        if (data != null && data.isScraped()) {
+            // Bitmap may have been recycled, must be removed from the cache and not
+            // returned to the component.
+            mPools.remove(key);
+            data.evicted();
+            return null;
         }
+        return data;
     }
 
     @Override
@@ -74,24 +71,18 @@ public void release(@NonNull ImageRecycleObject data) {
 
     @Override
     public void release(@NonNull ImageDataKey key, @NonNull ImageRecycleObject data) {
-        synchronized (mLock) {
-            mPools.put(key, data);
-            data.cached();
-        }
+        mPools.put(key, data);
+        data.cached();
     }
 
     @Override
     public void clear() {
-        synchronized (mLock) {
-            mPools.evictAll();
-        }
+        mPools.evictAll();
     }
 
     @Override
     public void remove(@NonNull ImageDataKey key) {
-        synchronized (mLock) {
-            mPools.remove(key);
-        }
+        mPools.remove(key);
     }
 
     private void onEntryEvicted(@NonNull ImageRecycleObject data) {