Fix incorrect proxy request address type for IPv6 #735
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Kenanbatmaz2
approved these changes
Sep 12, 2022
Kasbr305
suggested changes
Jan 28, 2023
Kasbr305
approved these changes
Jan 28, 2023
|
It has been a year since I submitted this Pull Request. The issue is quite severe, yet it only requires 10 lines of code to fix it. Additionally, two reviewers have already confirmed the code. I must say, your approach towards contributions from the open-source community leaves much to be desired. |
|
/cc @laktyushin |
|
@laktyushin when can you merge this? |
xximwon
approved these changes
Dec 12, 2024
xximwon
approved these changes
Jan 3, 2025
xximwon
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered years ago that both the iOS and Mac versions of Telegram send requests to the proxy server for invalid IP , and I created this issue in the TelegramSwift repo about two years ago but got no response. overtake/TelegramSwift#427
So I decided to look into it myself, and I found that MtProtoKit doesn't handle IPv6 addresses correctly at all, so when the upper-level code tries to connect to an IPv6 address via a proxy, it sends a request to an invalid IPv4 address.
This issue has been bugging me for years. Please merge this PR or fix the issue in some other way as soon as possible, thanks.