IOS-10544 Add safe concurrency in Feedback completion #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandroruizponce
requested review from
a team,
pbartolome and
cbarcom
and removed request for
a team
cbarcom
approved these changes
Dec 5, 2024
pbartolome
approved these changes
Dec 9, 2024
alejandroruizponce
deleted the
IOS-10544-Fix-Sendable-completion-Feedback
branch
|
🎉 This PR is included in version 33.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-10544
🥅 What's the goal?
Due to the migration to Swift 6 with strict concurrency that we are doing in Novum it is necessary to add some changes in the completion of Feedback so that it can be compatible with apps migrated in Swift 6.
🚧 How do we do it?
Since it is a visual component that requires UI actions, its completion action is isolated in a main actor environment and its parameters will be
Sendableto ensure safe concurrency.🧪 How can I verify this?
This fix will be used from this PR in Novum:
https://github.com/Telefonica/iphoneapp/pull/1792